Remove $isFinal dead-code in PhpFunctionReflection

phpstan · Oct 3, 2024 · 0f0cc65 · 0f0cc65
1 parent d944b5b
commit 0f0cc65
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/src/Reflection/BetterReflection/BetterReflectionProvider.php b/src/Reflection/BetterReflection/BetterReflectionProvider.php
@@ -304,7 +304,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 		$deprecatedTag = null;
 		$isDeprecated = false;
 		$isInternal = false;
-		$isFinal = false;
 		$isPure = null;
 		$asserts = Assertions::createEmpty();
 		$acceptsNamedArguments = true;
@@ -327,7 +326,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 			$deprecatedTag = $resolvedPhpDoc->getDeprecatedTag();
 			$isDeprecated = $resolvedPhpDoc->isDeprecated();
 			$isInternal = $resolvedPhpDoc->isInternal();
-			$isFinal = $resolvedPhpDoc->isFinal();
 			$isPure = $resolvedPhpDoc->isPure();
 			$asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
 			if ($resolvedPhpDoc->hasPhpDocString()) {
@@ -348,7 +346,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 			$deprecatedTag !== null ? $deprecatedTag->getMessage() : null,
 			$isDeprecated,
 			$isInternal,
-			$isFinal,
 			$reflectionFunction->getFileName() !== false ? $reflectionFunction->getFileName() : null,
 			$isPure,
 			$asserts,

diff --git a/src/Reflection/FunctionReflectionFactory.php b/src/Reflection/FunctionReflectionFactory.php
@@ -25,7 +25,6 @@ public function create(
 		?string $deprecatedDescription,
 		bool $isDeprecated,
 		bool $isInternal,
-		bool $isFinal,
 		?string $filename,
 		?bool $isPure,
 		Assertions $asserts,

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -48,7 +48,6 @@ public function __construct(
 		private ?string $deprecatedDescription,
 		private bool $isDeprecated,
 		private bool $isInternal,
-		private bool $isFinal,
 		private ?string $filename,
 		private ?bool $isPure,
 		private Assertions $asserts,