Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: various updates / PHP 8.1 should no longer be allowed to fail #26

Merged
merged 3 commits into from
Dec 7, 2021
Merged

GH Actions: various updates / PHP 8.1 should no longer be allowed to fail #26

merged 3 commits into from
Dec 7, 2021

Commits on Dec 4, 2021

  1. GH Actions: auto-cancel previous builds for same branch 

    Previously, in Travis, when the same branch was pushed again and the "Auto cancellation" option on the "Settings" page had been turned on (as it was for most repos), any still running builds for the same branch would be stopped in favour of starting the build for the newly pushed version of the branch.

To enable this behaviour in GH Actions, a `concurrency` configuration needs to be added to each workflow for which this should applied to.

More than anything, this is a way to be kind to GitHub by not wasting resources which they so kindly provide to us for free.

Refs:
* https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/
* https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
    @jrfnl
    jrfnl committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    0b2cf52 View commit details
    Browse the repository at this point in the history

  2. GH Actions/test workflow: further improve base ini values 

    Follow up on 24

Depending on the PHP version, `E_ALL` may not actual include all errors, so let's use `-1` instead which always will.
Also, let's enable `zend.assertions` in the ini settings as those may be used in tests.
    @jrfnl
    jrfnl committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    4f98f9d View commit details
    Browse the repository at this point in the history

  3. GH Actions: PHP 8.1 is no longer allowed to fail 

    PHP 8.1 was released the other week, so builds against PHP 8.1 should no longer be allowed to fail.
    @jrfnl
    jrfnl committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    a41ce0d View commit details
    Browse the repository at this point in the history