PHPCS: various improvements #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHPCS: add a PHPCS configuration file containing all the common command-line parameters.
This file will be automatically picked up by PHPCS and can be overruled locally by a `[.]phpcs.xml` file.
Includes downgrading the cyclomatic complexity error to a warning.
* Ant: remove the configuration CLI arguments which are now contained in the `phpcs.xml.dist` file from the `build.xml` task configuration.
* Ant: add a CLI argument which will ignore CS warnings when determining the exit code, but will still _show_ warnings in the report.
Using this will also allow for enabling `failonerror` for the build step.
* Git: Add the `phpcs.xml.dist` file to the `.gitattributes` file to be ignored when packaging a release.
* Git: Add the potential local overload files to the `.gitignore` file.
|
@grogy Anything I can do to move this PR forward ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file will be automatically picked up by PHPCS and can be overruled locally by a
[.]phpcs.xmlfile.Includes downgrading the cyclomatic complexity error to a warning.
phpcs.xml.distfile from thebuild.xmltask configuration.Using this will also allow for enabling
failonerrorfor the build step.phpcs.xml.distfile to the.gitattributesfile to be ignored when packaging a release..gitignorefile.