PHP 8.0: handle changed tokenization of namespaced names #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Namespaced names are now represented using the `T_NAME_QUALIFIED` (`Foo\Bar`), `T_NAME_FULLY_QUALIFIED` (`\Foo\Bar`) and `T_NAME_RELATIVE` (`namespace\Foo\Bar`) tokens. `T_NS_SEPARATOR` is only used for standalone namespace separators, and only syntactially valid in conjunction with group use declarations. Ref: https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.tokenizer This commit: * Adds recognition for the new PHP 8.0 tokens for namespaced names and highlights these as `TOKEN_DEFAULT`, same as a non-namespaced `T_STRING` name. * Adjusts the new unit tests to document the different highlighting between PHP < 8.0 and PHP 8.0+. I've chosen not to make force the same highlighting across versions, but to let the highlighting respect the different tokenization across PHP versions.
|
@grogy Anything I can do to move this PR forward ? |
|
Thank you for create compatible changeset with old PHP versions |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: add tests covering namespaced names
PHP 8.0: handle changed tokenization of namespaced names
Ref: https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.tokenizer
This commit:
TOKEN_DEFAULT, same as a non-namespacedT_STRINGname.I've chosen not to make force the same highlighting across versions, but to let the highlighting respect the different tokenization across PHP versions.