Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: update allowed version for various dependencies #12

Merged

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jun 28, 2020

Non-dev:

  • PHP Console Color has released version 0.3 in May.
    I've set it to allow both 0.2 as well as 0.3 to prevent conflicts.
    Packages which use this package which may have the Console Color package explicitly set as a requirement.

Dev:

  • PHP Parallel Lint has released version 1.2.0 in April.
  • PHP Var dump check has released version 0.4 in April.
    I've set this one to be a flexible requirement to prevent having to update it on each new version.
  • PHP_CodeSniffer has moved on a lot since version 1.5, so let's use a more recent one.

As it was, installing with PHP Console Color 0.3 was not allowed as Composer treats minors < 1.0 as majors.
So updating to that version requires an update to the composer.json requirements.

For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0.

Refs:

Non-dev:
* PHP Console Color has released version 0.3 in May.
    I've set it to allow both `0.2` as well as `0.3` to prevent conflicts.
    Packages which use this package which may have the Console Color package explicitly set as a requirement.

Dev:
* PHP Parallel Lint has released version 1.2.0 in April.
* PHP Var dump check has released version 0.4 in April.
    I've set this one to be a flexible requirement to prevent having to update it on each new version.
* PHP_CodeSniffer has moved on a lot since version 1.5, so let's use a more recent one.

As it was, installing with PHP Console Color 0.3 was not allowed as Composer treats minors < 1.0 as majors.
So updating to that version requires an update to the `composer.json` requirements.

> For pre-1.0 versions it also acts with safety in mind and treats `^0.3` as `>=0.3.0 <0.4.0`.

Refs:
* https://getcomposer.org/doc/articles/versions.md#caret-version-range-
* https://github.com/php-parallel-lint/PHP-Console-Color/releases/tag/v0.3
* https://github.com/php-parallel-lint/PHP-Parallel-Lint/releases/tag/v1.2.0
* https://github.com/php-parallel-lint/PHP-Var-Dump-Check/releases/tag/v0.4
@jrfnl jrfnl force-pushed the feature/composer-update-dependencies branch from 4149bbb to dc7120d Compare June 28, 2020 21:50
@jrfnl
Copy link
Collaborator Author

jrfnl commented Jul 20, 2020

@grogy Any chance of this PR getting some love ?

@grogy
Copy link
Member

grogy commented Jul 24, 2020

Thank you. The point for <1.0 version is good.

@grogy grogy merged commit fb6004a into php-parallel-lint:master Jul 24, 2020
@jrfnl jrfnl deleted the feature/composer-update-dependencies branch July 24, 2020 14:44
@jrfnl jrfnl added this to the 1.0.0 milestone Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants