Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeferredResult to SpringRestController #272

Closed
wants to merge 1 commit into from
Closed

Add DeferredResult to SpringRestController #272

wants to merge 1 commit into from

Conversation

godmarch33
Copy link

@godmarch33 godmarch33 commented Aug 29, 2018

1 Add DefferedResult to SpringRestController
2 Add test for SpringControllerDefferedResult
3 update tests naming files for async type
4 apply formatter plugin

@stojsavljevic
Copy link
Contributor

Hi,

thanks for the PR.
Something I noticed:

  • as far as I can see, changes in pom.xml are not required
  • code in BaseControllerDecoratorAsyncDeferredResult.java.txt doesn't compile since interface specifies DeferredResult<ResponseEntity<NamedResponseType>> as return type for getNamedResponseTypeById method and implementation returns DeferredResult<NamedResponseType>; this probably means some additional coding
  • I would like that isDeferredResult() check in rules comes after other checks like isCallableResponse()
  • please drop all formatting changes like javadoc in SpringControllerDecoratorRule.java for example
  • please fix javadoc in newly generated files; you don't have to provide an example but describe what class does, add proper @author and @since tags etc

@stojsavljevic
Copy link
Contributor

Support for DeferredResult is added as part of #257.
Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants