fix enrollment tab beans silently refreshed from DataTable.filter() #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrenn
requested review from
fladi,
VeitWeber,
Kalandus,
Jensrib,
codonAG2,
SigridDeller,
ultchagen,
01hasenberger and
UniDeb
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates initiate from within enrollement tabs, such adding an enrollment status use primeface's clientside PrimeFaces.widget.DataTable.prototype.filter().
this in turn will silently cause to re-select the current row (subject list entry), which re-inits all the enrollment tab beans, effectively re-setting them. this also caused an issue observed in particular: deleting fails (with no error) after an intermediate enrollment status creation.
re-selecting the current row is now prevented by doing unselectAllRows() beforehand.