Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong scaling in divide_by_N_sqrt #42

Merged
merged 3 commits into from
Jul 20, 2022
Merged

fix wrong scaling in divide_by_N_sqrt #42

merged 3 commits into from
Jul 20, 2022

Conversation

phip1611
Copy link
Owner

No description provided.

@phip1611 phip1611 self-assigned this Jul 17, 2022
@phip1611 phip1611 mentioned this pull request Jul 17, 2022
Closed
@phip1611 phip1611 linked an issue Jul 17, 2022 that may be closed by this pull request
Basic scaling method is missing (val / sqrt(len)) #41
Closed
@spitfire05
Copy link

Yes, this does look like divide_by_N_sqrt is giving expected results now.

@phip1611 phip1611 merged commit fccf00c into main Jul 20, 2022
@phip1611 phip1611 deleted the fix-divide-by-n-sqrt branch July 20, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phip1611 phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic scaling method is missing (val / sqrt(len))
2 participants
@phip1611 @spitfire05