feat: move starting the DAC channel to the constructor to avoid a 1ms…

… delay loop every time the Dac value is set (#387)
philips-software · Sep 2, 2024 · 8211b8c · 8211b8c
1 parent ad1e53a
commit 8211b8c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/hal_st/stm32fxxx/DigitalToAnalogPinStm.cpp b/hal_st/stm32fxxx/DigitalToAnalogPinStm.cpp
@@ -19,32 +19,44 @@ namespace hal
         : dac{ dac }
         , channel{ infra::enum_cast(channel) == 1 ? DAC_CHANNEL_1 : DAC_CHANNEL_2 }
         , internallyConnected{ true }
-    {}
+    {
+        Configure();
+    }
 
     DigitalToAnalogPinImplStm::DigitalToAnalogPinImplStm(hal::GpioPinStm& pin, hal::DacStm& dac, External)
         : pin{ infra::inPlace, pin }
         , dac{ dac }
         , channel{ pin.DacChannel(dac.index + 1) == 1 ? DAC_CHANNEL_1 : DAC_CHANNEL_2 }
         , internallyConnected{ false }
-    {}
+    {
+        Configure();
+    }
 
     DigitalToAnalogPinImplStm::DigitalToAnalogPinImplStm(hal::GpioPinStm& pin, hal::DacStm& dac, Both)
         : pin{ infra::inPlace, pin }
         , dac{ dac }
         , channel{ pin.DacChannel(dac.index + 1) == 1 ? DAC_CHANNEL_1 : DAC_CHANNEL_2 }
         , internallyConnected{ true }
 
-    {}
+    {
+        Configure();
+    }
 #else
     DigitalToAnalogPinImplStm::DigitalToAnalogPinImplStm(hal::GpioPinStm& pin, hal::DacStm& dac)
         : pin{ infra::inPlace, pin }
         , dac(dac)
         , channel{ pin.DacChannel(dac.index + 1) == 1 ? DAC_CHANNEL_1 : DAC_CHANNEL_2 }
     {
+        Configure();
     }
 #endif
 
     void DigitalToAnalogPinImplStm::Set(uint16_t value)
+    {
+        dac.Set(channel, DAC_ALIGN_12B_R, std::min(static_cast<uint32_t>(value), (infra::Bit<uint32_t>(12) - 1)));
+    }
+
+    void DigitalToAnalogPinImplStm::Configure()
     {
         DAC_ChannelConfTypeDef sConfig{ 0 };
         sConfig.DAC_OutputBuffer = pin ? DAC_OUTPUTBUFFER_ENABLE : DAC_OUTPUTBUFFER_DISABLE;
@@ -64,8 +76,6 @@ namespace hal
 
         result = HAL_DAC_Start(&dac.handle, channel);
         assert(result == HAL_OK);
-
-        dac.Set(channel, DAC_ALIGN_12B_R, std::min(static_cast<uint32_t>(value), (infra::Bit<uint32_t>(12) - 1)));
     }
 
     DacStm::DacStm(uint8_t oneBasedIndex)

diff --git a/hal_st/stm32fxxx/DigitalToAnalogPinStm.hpp b/hal_st/stm32fxxx/DigitalToAnalogPinStm.hpp
@@ -43,6 +43,8 @@ namespace hal
         void Set(uint16_t value) override;
 
     private:
+        void Configure();
+
         infra::Optional<AnalogPinStm> pin;
         DacStm& dac;
         uint32_t channel;