fix: timer limited repeat #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0.06s | |
| ✅ CPP | clang-format | 965 | 2 | 0 | 6.25s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0.1s | |
| ✅ JSON | jsonlint | 9 | 0 | 0.15s | |
| ✅ JSON | prettier | 9 | 0 | 0 | 0.64s |
| markdownlint | 6 | 0 | 4 | 1.52s | |
| markdown-link-check | 6 | 1 | 78.5s | ||
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0.32s |
| ✅ REPOSITORY | checkov | yes | no | 21.23s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.07s | |
| ✅ REPOSITORY | grype | yes | no | 18.36s | |
| ✅ REPOSITORY | secretlint | yes | no | 7.34s | |
| ✅ REPOSITORY | trivy | yes | no | 12.2s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | 0.65s | |
| ✅ REPOSITORY | trufflehog | yes | no | 2.95s | |
| lychee | 139 | 4 | 3.27s | ||
| prettier | 22 | 0 | 1 | 0.99s | |
| ✅ YAML | v8r | 22 | 0 | 9.54s | |
| ✅ YAML | yamllint | 22 | 0 | 0.41s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
|
| @@ -85,24 +85,34 @@ namespace infra | |||
| void ComputeNextTriggerTime() override; | |||
| }; | |||
|
|
|||
| namespace details | |||
There was a problem hiding this comment.
For consistency with other detail namespaces:
Suggested change
| namespace details | |
| namespace detail |
| { | ||
| public: | ||
| explicit TimerLimitedRepeatingWithClosingAction(uint32_t timerServiceId = systemTimerServiceId); | ||
| TimerLimitedRepeatingWithClosingAction(int aHowMany, Duration duration, const infra::Function<void()>& action, const infra::Function<void()>& aClosingAction, uint32_t timerServiceId = systemTimerServiceId); | ||
|
|
||
| void Start(int aHowMany, Duration duration, const infra::Function<void()>& action, const infra::Function<void()>& aClosingAction); | ||
| virtual const infra::Function<void()>& Action() const override; |
There was a problem hiding this comment.
Suggested change
| virtual const infra::Function<void()>& Action() const override; | |
| const infra::Function<void()>& Action() const override; |
richardapeters
approved these changes
Jun 21, 2024
richardapeters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimerLimitedRepeating did not work on our project.
Refactored TimerLimitedRepeating and TimerLimitedRepeatingWithClosingAction to be aglined with TimerRepeating.
Added test cases for the 'Cancel'