Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed infra::Optional to use std::optional as its base type #624

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

daantimmer
Copy link
Contributor

This marks the beginning of deprecating infra::Optional in favour of std::optional. With this change usages of infra::Optional can be slowly replaced by std::optional.

This marks the beginning of deprecating infra::Optional in favour of std::optional. With this change usages of infra::Optional can be slowly replaced by std::optional.
@daantimmer daantimmer requested a review from a team as a code owner May 3, 2024 22:26
Copy link
Contributor

github-actions bot commented May 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented May 3, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.05s
✅ CPP clang-format 958 2 0 6.71s
✅ DOCKERFILE hadolint 2 0 0.11s
✅ JSON jsonlint 9 0 0.25s
✅ JSON prettier 9 0 0 1.02s
⚠️ MARKDOWN markdownlint 6 0 4 1.58s
⚠️ MARKDOWN markdown-link-check 6 1 61.5s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.4s
✅ REPOSITORY checkov yes no 18.19s
✅ REPOSITORY git_diff yes no 0.08s
✅ REPOSITORY grype yes no 14.67s
✅ REPOSITORY secretlint yes no 7.73s
✅ REPOSITORY trivy yes no 4.78s
✅ REPOSITORY trivy-sbom yes no 3.11s
✅ REPOSITORY trufflehog yes no 2.87s
⚠️ SPELL lychee 137 2 2.03s
⚠️ YAML prettier 22 0 1 1.14s
✅ YAML v8r 22 0 95.85s
✅ YAML yamllint 22 0 0.42s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.6% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant