Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15930 psr link #15944

Merged
merged 4 commits into from
Apr 20, 2022
Merged

T15930 psr link #15944

merged 4 commits into from
Apr 20, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Apr 19, 2022 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed PSR dependency from Phalcon\Html\Link\*. Added interfaces based on PSR but with stricter types, added Abstract classes to be used by the proxy-psr13 repo.

Thanks

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Apr 19, 2022
@niden niden requested a review from Jeckerson April 19, 2022 02:37
@niden niden self-assigned this Apr 19, 2022
@niden niden changed the base branch from master to 5.0.x April 19, 2022 02:37
@niden niden linked an issue Apr 19, 2022 that may be closed by this pull request
[NFR]: Remove Link PSR dependency #15930
Closed
@niden niden merged commit 2de9633 into phalcon:5.0.x Apr 20, 2022
@niden niden deleted the T15930-psr-link branch April 20, 2022 01:46
@niden niden mentioned this pull request Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Remove Link PSR dependency
2 participants
@niden @Jeckerson