Don't send dispatcher parameters #13123
Conversation
These will erase previously set variables, and dispatcher's params were never accessible this way so far, so removing the argument in this function is fine.
|
@Jurigag thanks, that should do the trick! Hope the release will happen soon (o.o') |
|
Update changelog also but whatever. |
|
Sorry, forgot that too :-( Updating right now! |
|
You mean this file? So I add a 3.2.4? |
|
Yes |
|
Updated, waiting for rebuild. Thanks @Jurigag for your help. |
|
I will keep this open for a day or two to allow other contributors a chance to speak up, and to take a fresh look at it later. Anyway we can to release this on weekends. But at the moment it seems good to me. Thank you or contributing! |
|
You're welcome. I've fixed my code where I've found exceptions (variable changed from an object to a scalar value, ouch), so for now it's «okay». But I'll revert my own code when this fix goes live :-) |
|
The point is to release it soon before a lot of people upgrade to 3.2.3 and face this very issue. Hope there's not a lot of them :-) If it's in about a week or so, that's great! |
|
Thank you |
Small description of change:
These will erase previously set variables, and dispatcher's params were never accessible this way so far, so removing the argument in this function is fine.