Prevent invalid element name #12954
Merged
Prevent invalid element name #12954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent create form element with empty name value like ''
sergeyklay
suggested changes
Jul 17, 2017
phalcon/forms/element.zep
Outdated
| let name = trim(name); | ||
|
|
||
| if empty name { | ||
| throw new \InvalidArgumentException('Form element name is required'); |
There was a problem hiding this comment.
throw new \InvalidArgumentException('...'); =>throw new \InvalidArgumentException("...");
|
@emiliodeg What do you want to fix? Could you please describe a bit more the issue? Also can you create a small test which will cover code you have changed? Thank you for contributing. |
|
Hi @sergeyklay I trying to prevent this posible error new \Phalcon\Form\Element\Text(''); // empty name
new \Phalcon\Form\Element\TextArea(' '); // empty name |
|
@emiliodeg Anyway you have to use |
sergeyklay
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
@emiliodeg Looks good to me. Could you please update the CHANGELOG.md
chilimatic
pushed a commit
to chilimatic/cphalcon
that referenced
this pull request
Jan 15, 2018
* Prevent invalid element name Prevent create form element with empty name value like '' * trim name * Update element.zep * Update element.zep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent create form element with empty name value like ''
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Thanks