-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to manager so CSS and JS resources are not mixed when outputing by type #12915
Add filter to manager so CSS and JS resources are not mixed when outputing by type #12915
Conversation
@ninjapanzer Could you please update the |
db3c7f1
to
ec020d2
Compare
ec020d2
to
52b3fa4
Compare
@sergeyklay ChangeLog Updated. |
CHANGELOG.md
Outdated
@@ -46,6 +46,7 @@ | |||
- Fixed `Phalcon\Cache\Backend\Redis::__construct` and `Phalcon\Cache\Backend\Redis::_connect` to correctly handle the Redis auth option [#12736](https://github.com/phalcon/cphalcon/issues/12736) | |||
- Fixed `Phalcon\Mvc\Collection::getReservedAttributes`, added missing properties to reserved attributes [phalcon/incubator#762](https://github.com/phalcon/incubator/issues/762), [phalcon/incubator#760](https://github.com/phalcon/incubator/issues/760) | |||
- Fixed `Phalcon\Mvc\Router\Annotation::processActionAnnotation` to support PATCH request | |||
- Fixed `Phalcon\Assets\Manager::output`, implemented missing resource type filtering for mixed resource collections [#2408](https://github.com/phalcon/cphalcon/issues/2408) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be on 3.2.1 block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... sorry, fixed.
52b3fa4
to
765d74b
Compare
Thank you |
Hello!
In raising this pull request, I confirm the following (please check boxes):
This PR adds a filter method which returns a new copy of the collection resources array that only includes the supplied type. So that a collection an contain a mix of JS and CSS resources so that:
outputJs
will only return js resources from that collectionoutputCss
will only return css resources from that collectionThanks
Paul Scarrone(ninjapanzer)paul@savvysoftworks.com