Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Unused Phalcon\Mvc\Router::uriSource #15123

Closed
Jurigag opened this issue Jul 29, 2020 · 1 comment · Fixed by #15147
Closed

[BUG]: Unused Phalcon\Mvc\Router::uriSource #15123

Jurigag opened this issue Jul 29, 2020 · 1 comment · Fixed by #15147
Assignees
@zsilbi
Labels
bug A bug report

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Jul 29, 2020

Describe the bug
This property is not used anywhere.

Expected behavior
Remove it in next version

Details

  • Phalcon version: 4.0.6
  • PHP Version: 7.4
  • Operating System: ubuntu 18.04
  • Installation type: Compiling from source
  • Zephir version (if any): 0.12.19
  • Server: Other
  • Other related info (Database, table schema):
@Jurigag Jurigag added bug A bug report status: unverified Unverified labels Jul 29, 2020
@Jurigag Jurigag changed the title [BUG]: Unusued Phalcon\Mvc\Router::uriSource [BUG]: Unused Phalcon\Mvc\Router::uriSource Jul 29, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 10, 2020
@zsilbi
fix(router): removed unused property
9f7e8c2 
Refs phalcon#15123
@zsilbi zsilbi added 4.1.0 and removed status: unverified Unverified labels Sep 10, 2020
@zsilbi zsilbi self-assigned this Sep 10, 2020
@zsilbi zsilbi mentioned this issue Sep 10, 2020
Merged
3 tasks
@zsilbi zsilbi linked a pull request Sep 11, 2020 that will close this issue
T15123 Remove Mvc\Router::uriSource #15147
Merged
3 tasks
@zsilbi
Copy link
Member

zsilbi commented Sep 11, 2020

Fixed in #15147

@zsilbi zsilbi closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsilbi zsilbi

Labels
bug A bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15123 Remove Mvc\Router::uriSource zsilbi/cphalcon
2 participants
@zsilbi @Jurigag