Rename property of pagination page object to be more intuitive

[scrnjakovic]

I propose changing before property of page object to previous which is far more intuitive for given context, as before goes better with after, not next.

I know this is minor and breaks BC, but maybe we can do it in 4.0? Or for some time, allow both properties.

EDIT: I also think that having total_pages and last is a bit redundant. I propose removing last.

EDIT2: I'd also rename $paginator->getPaginate() to either $paginator->getPage() or $paginator->paginate() for the same reason - being more intuitive.

[niden]

I agree with these changes, it will make things a bit more logical I think.

We can implement this right now for the next minor release but we will need to keep both versions available to keep backwards compatibility for 4.0 version as well. We can deprecate the old properties after 4.0.

In summary:

• Introduce one more element called previous which will have the same value as before
• Add a method called paginate() which will produce the same result as getPaginate()
• Keep total_pages for now to be later removed since the same information is in last
• Add @deprecated to getPaginate() to inform the developers that this will be removed after 4.0

[niden]

@phalcon/core-team Thoughts?

[Jurigag]

Overall i agree. If we are going to release next minor version then we can add new methods.

[niden]

Implemented