[2.1.x] Dispatcher doesn't forward when handling exception in PHP5.6

[virgofx]

Code works in 2.0.x. It may have to do with the creation of the new _dispatch() method in 2.1.x and multiple levels of try/catch which do not work well in zephir.

Pseudo code:

bootstrap

$di = new \Phalcon\Di\FactoryDefault();

$eventsManager = new \Phalcon\Events\Manager();
$eventsManager->attach('dispatch:beforeException', function($event, $dispatcher, $exception) {
    $dispatcher->forward([
        'controller' => 'test',
        'action' => 'second'
    ]);
    // Prevent the exception from bubbling
    return false;
});

$dispatcher = new \Phalcon\Mvc\Dispatcher();
$dispatcher->setEventsManager($eventsManager);

$di->setShared('dispatcher', $dispatcher);

$application = new \Phalcon\Mvc\Application();
$application->setEventsManager(new \Phalcon\Events\Manager());
$application->setDI($di);

echo $application->handle()->getContent();

TestController.php

class TestController extends \Phalcon\Mvc\Controller
{
    public function indexAction()
    {
        throw new \Exception('whups bad controller');
    }

    public function secondAction() 
    {
        echo 'I should be displayed';
        exit;
    }
}

[temuri416]

Hi @virgofx, is there any progress on this issue?

Thanks!

[virgofx]

@temuri416 We have it fixed; however, still waiting on a core bug in Zephir land which causes a segfault in the updated tests that would allow this to pass and get things merged in. So still in a holding pattern. Anxiously waiting help from @andresgutierrez to help with zephir-lang/zephir#1325. Perhaps if you want to add another ping in that thread -- might help. In the meantime, I've had to override the dispatcher manually which fixes this in our production boxes - If you need this snippet email me directly and I can share with you.

[temuri416]

@andresgutierrez Can we please have your attention? We need your help to get the issue fixed. Thank you!

[sergeyklay]

Fixed in the 3.2.x branch.

[temuri416]

Verified, working as expected! This is an enormous improvement, thanks a lot.

[mladen7]

A bit late to the party but having the same problem at the moment... Using php 5.6.10 and phalcon 3.2.4 version, i cannot forward either from the beforeException or the beforeExecuteRoute methods.. When i try to forward from the beforeExecuteRoute, i trigger a dispatch cycle loop eventually being picked up by the beforeException, which then also does not manage to forward but returns the index page.. I used the basic INVO tutorial available on the phalcon docs website.. Relevant code follows:
bootstrap

    $eventsManager = new EventsManager();
    // Listen for events produced in the dispatcher using the Security plugin
    $eventsManager->attach(
        'dispatch:beforeExecuteRoute',
        new \Plugins\SecurityPlugin()
    );

    // Handle exceptions and not-found exceptions
    $eventsManager->attach(
        'dispatch:beforeException',
        new \Plugins\NotFoundPlugin()
    );

    $dispatcher = new Dispatcher();

    // Assign the events manager to the dispatcher

    $dispatcher->setEventsManager($eventsManager);

    return $dispatcher;
}, true);

not found plugin

public function beforeException($event, Dispatcher $dispatcher, $exception) {
        switch ($exception->getCode()) {
            case Dispatcher::EXCEPTION_HANDLER_NOT_FOUND:
            case Dispatcher::EXCEPTION_ACTION_NOT_FOUND:
                $dispatcher->forward(
                    array(
                        'namespace'  => 'Controllers',
                        'controller' => 'GenericError',
                        'action'     => 'handleRoute404'
                    )
                );
                return false;
            default:
                $dispatcher->forward(
                    array(
                        'namespace'  => 'Controllers',
                        'controller' => 'GenericError',
                        'action'     => 'handleError'
                    )
                );
                return false;
        }
    }

security plugin

// Authorize
        $roleFromToken = $this->authorize();
        if (is_null($roleFromToken)) {
            $dispatcher->forward(
                [
                    'namespace'  => 'Controllers',
                    'controller' => 'GenericError',
                    'action'     => 'handle401',
                    
                ]
            );
            return false; }

any ideas will be greatly appreciated. Thanks