Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Asset management, make resource collection be a Set #10938

Closed
Dimous opened this issue Sep 12, 2015 · 4 comments
Closed

[Feature] Asset management, make resource collection be a Set #10938

Dimous opened this issue Sep 12, 2015 · 4 comments
Assignees
@sergeyklay
Milestone
3.2.0

Comments

@Dimous
Copy link

Dimous commented Sep 12, 2015

I made widgets, that autoregister their own css/js. When I use multiple instances of a widget, its link/script entries get duplicated.
@andresgutierrez andresgutierrez added the need script to reproduce Script is required to reproduce the issue label Sep 12, 2015
@Dimous
Copy link
Author

Dimous commented Sep 13, 2015

This snippet reproduces resource registering behaviour of 10 instances of a widget:
for ($nIndex = 0; $nIndex < 10; ++ $nIndex) $this->assets->addCss("style.css")->addJs("script.js");

KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 13, 2015
@KorsaR-ZN
added new feature phalcon#10938
f5877d1
@KorsaR-ZN KorsaR-ZN mentioned this issue Sep 13, 2015
Closed
KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 25, 2015
@KorsaR-ZN
added new feature phalcon#10938
5dab02a
KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 26, 2015
@KorsaR-ZN
added new feature phalcon#10938
2013168
KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 26, 2015
@KorsaR-ZN
added new feature phalcon#10938
ca17f22
@Dimous
Copy link
Author

Dimous commented Aug 5, 2016

Oy vey! Feature #10938 is still not merged!

@sergeyklay
Copy link
Contributor

It may be part of 3.1.0

@sergeyklay sergeyklay added this to the 3.1.0 milestone Oct 16, 2016
@sergeyklay sergeyklay removed the need script to reproduce Script is required to reproduce the issue label Oct 16, 2016
@sergeyklay sergeyklay modified the milestones: 3.2.0, 3.1.0 Mar 17, 2017
@sergeyklay sergeyklay self-assigned this Jun 2, 2017
@sergeyklay sergeyklay mentioned this issue Jun 2, 2017
Merged
@sergeyklay
Copy link
Contributor

Implemented in 3.2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@andresgutierrez @Dimous @sergeyklay