Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed regression #18

Open
ktmeaton opened this issue Dec 8, 2023 · 2 comments
Open

Speed regression #18

ktmeaton opened this issue Dec 8, 2023 · 2 comments

Comments

@ktmeaton
Copy link
Collaborator

ktmeaton commented Dec 8, 2023

Somewhere between 4756dce and 967674e, I made changes that had significant speed impacts :( The sars-cov-2 dataset went down from 100 sequences/sec to < 1 seq/sec 😢 going to walk back those changes to identify the problem.
@ktmeaton
Copy link
Collaborator Author

ktmeaton commented Dec 8, 2023

The culprit is b096173, let this be a lesson to myself to not make such big changes at a time.

https://github.com/phac-nml/rebar/compare/c644c9730009..b0961738

b096173 changes:

  • Wildcarding in designated parents.
  • More thorough compare_parents validation for parent-child relationships.
  • Removing min_conflict option for best hypothesis.
  • KnockoutRecombinant Hypothesis

@ktmeaton
Copy link
Collaborator Author

ktmeaton commented Dec 8, 2023 •
edited
Loading

It's purely the new KnockoutRecombinant hypothesis! Well that is very curious, but luckily the easiest to undo and troubleshoot.

Update: Maybe not, to be continued!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktmeaton