Skip to content

Commit

Permalink
Bubble up SubProcessError to basecommand._main
Browse files Browse the repository at this point in the history
  • Loading branch information
deveshks committed May 23, 2020
1 parent ab3ee71 commit e9f738a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/pip/_internal/cli/base_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
CommandError,
InstallationError,
PreviousBuildDirError,
SubProcessError,
UninstallationError,
)
from pip._internal.utils.deprecation import deprecated
Expand Down Expand Up @@ -201,7 +202,8 @@ def _main(self, args):
logger.debug('Exception information:', exc_info=True)

return PREVIOUS_BUILD_DIR_ERROR
except (InstallationError, UninstallationError, BadCommand) as exc:
except (InstallationError, UninstallationError, BadCommand,
SubProcessError) as exc:
logger.critical(str(exc))
logger.debug('Exception information:', exc_info=True)

Expand Down

0 comments on commit e9f738a

Please sign in to comment.