Skip to content
This repository has been archived by the owner on Feb 19, 2018. It is now read-only.

Commit

Permalink
Switch to node-sass (from node-sass-chokidar)
Browse files Browse the repository at this point in the history
It looks like `node-sass-chokidar` doesn't play as nicely with npm
SCSS modules like Bourbon, so we're switching it out in favor of
the base node-sass.

The chokidar version won't work with paths.js, since you have to
pass the include paths as arguments to the script in package.json.

This makes sense, but the main reason for not using the base node-sass
was apparently [a problem with Mac + docker](facebook/create-react-app#1986)
which for better or wose is not at play in my dev environment.
  • Loading branch information
Michael Schuller committed Jul 20, 2017
1 parent 363a46a commit 4763e46
Show file tree
Hide file tree
Showing 3 changed files with 86 additions and 9 deletions.
91 changes: 84 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,98 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"autoprefixer": "7.1.1",
"axios": "^0.16.2",
"babel-core": "6.25.0",
"babel-eslint": "7.2.3",
"babel-jest": "20.0.3",
"babel-loader": "7.0.0",
"babel-preset-react-app": "^3.0.1",
"babel-runtime": "6.23.0",
"case-sensitive-paths-webpack-plugin": "2.1.1",
"chalk": "1.1.3",
"classnames": "^2.2.5",
"css-loader": "0.28.4",
"dotenv": "4.0.0",
"eslint": "3.19.0",
"eslint-config-react-app": "^1.0.5",
"eslint-loader": "1.7.1",
"eslint-plugin-flowtype": "2.34.0",
"eslint-plugin-import": "2.2.0",
"eslint-plugin-jsx-a11y": "5.0.3",
"eslint-plugin-react": "7.1.0",
"extract-text-webpack-plugin": "2.1.2",
"file-loader": "0.11.2",
"fs-extra": "3.0.1",
"html-webpack-plugin": "2.29.0",
"jest": "20.0.4",
"moment": "^2.18.1",
"node-sass-chokidar": "0.0.3",
"object-assign": "4.1.1",
"postcss-flexbugs-fixes": "3.0.0",
"postcss-loader": "2.0.6",
"promise": "7.1.1",
"react": "^15.6.1",
"react-dev-utils": "^3.0.2",
"react-dom": "^15.6.1",
"react-error-overlay": "^1.0.9",
"react-router-dom": "^4.1.2",
"react-scripts": "1.0.10"
"style-loader": "0.18.2",
"sw-precache-webpack-plugin": "0.11.3",
"url-loader": "0.5.9",
"webpack": "2.6.1",
"webpack-dev-server": "2.5.0",
"webpack-manifest-plugin": "1.1.0",
"whatwg-fetch": "2.0.3"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject",
"build-css": "node-sass-chokidar src/ -o src/",
"watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive"
"start": "node scripts/start.js",
"build": "node scripts/build.js",
"test": "node scripts/test.js --env=jsdom"
},
"jest": {
"collectCoverageFrom": [
"src/**/*.{js,jsx}"
],
"setupFiles": [
"<rootDir>/config/polyfills.js"
],
"testMatch": [
"<rootDir>/src/**/__tests__/**/*.js?(x)",
"<rootDir>/src/**/?(*.)(spec|test).js?(x)"
],
"testEnvironment": "node",
"testURL": "http://localhost",
"transform": {
"^.+\\.(js|jsx)$": "<rootDir>/node_modules/babel-jest",
"^.+\\.css$": "<rootDir>/config/jest/cssTransform.js",
"^(?!.*\\.(js|jsx|css|json)$)": "<rootDir>/config/jest/fileTransform.js"
},
"transformIgnorePatterns": [
"[/\\\\]node_modules[/\\\\].+\\.(js|jsx)$"
],
"moduleNameMapper": {
"^react-native$": "react-native-web"
},
"moduleFileExtensions": [
"web.js",
"js",
"json",
"web.jsx",
"jsx"
]
},
"babel": {
"presets": [
"react-app"
]
},
"eslintConfig": {
"extends": "react-app"
},
"devDependencies": {
"bourbon": "^4.3.4",
"bourbon-neat": "^1.9.0",
"sass-loader": "^6.0.6"
}
}
2 changes: 1 addition & 1 deletion src/QuestionDetail.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import classNames from 'classnames';
import API_MAP from './APIMap';
import formatDate from './Util.js';

import './QuestionDetail.css';
import './QuestionDetail.scss';

export default class QuestionDetail extends Component {

Expand Down
2 changes: 1 addition & 1 deletion src/QuestionsList.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import axios from 'axios';
import API_MAP from './APIMap';
import formatDate from './Util.js';

import './QuestionsList.css';
import './QuestionsList.scss';

export default class QuestionsList extends Component {

Expand Down

0 comments on commit 4763e46

Please sign in to comment.