Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu support #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bltavares
Copy link

Hi there Petr,

We were using your project on our team and it was awesome.
But some of our team members used Ubuntu and they could not benefit from the notifications.

There was @crabhi's project that would do notifications for Ubuntu, forked from yours, but it would not allow us to have it running nicely with the Mac.

I forked the project to unify both works so we could use them on our team, but I believe that it would be nice to merge it back with your project.

If you like the changes, I would like to propose as well to change the name to karma-notification-reporter.
I have reserved the name on npm already and I would pass it to you.

I hope you enjoy the patch.

@petrbela
Copy link
Owner

Hey Bruno,

Thanks for the PR!

I have to think about whether it's a good idea to merge projects/functionalities, or if they should be separate. Moreover, an all-in-one "notification reporter" would also require native support for Windows at a minimum I guess (plus other Linux versions). So far I'm for keeping them separate but I'll give it a thought.

Btw, there isn't any conflict in including osx reporter alongside ubuntu reporter in one project, is there?

@crabhi
Copy link

crabhi commented Oct 14, 2014

Cool, I can see the benefit for having just one multi-platform reporter. The dependencies are often committed into VCS and multi platform tools make the life a bit easier for heterogeneous teams.

Aside - according to DBus docs, DBus "is present in all major Linux distributions" so it might work with other distros too. I just didn't want to claim it does because I never wanted to test nor support it.

@bltavares
Copy link
Author

@petrbela I'm not sure which tools are there for Windows. I believe there is Growl, but it was a long time ago since I stopped using Windows haha.

There was no major conflicts on having the mac dependency on linux, but having the linux dependency produces an error message on installation, but because it is optional, it is ignored.
I didn't find how to declare dependencies for specific OS on the npm documentation tho.

I will keep it separate for then, just let me know (:

@crabhi I believe it should work on other distros as well, but I haven't tried yet.
Thanks for the work on it! (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants