Add query parameters to delete request cache on heap and disk selectively #15
Conversation
kiranprakash154
changed the title
.../src/main/java/org/opensearch/action/admin/indices/cache/clear/ClearIndicesCacheRequest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/opensearch/action/admin/indices/cache/clear/ClearIndicesCacheRequest.java
Outdated
Show resolved
Hide resolved
|
|
||
| package org.opensearch.action; | ||
|
|
||
| public interface InputValidator { |
There was a problem hiding this comment.
I feel like something like this must already exist somewhere... seems like a general problem that many APIs would have to solve
|
|
||
| public void validateInput() { | ||
| if (requestCache && requestCacheOnDisk) { | ||
| throw new IllegalArgumentException("Invalid parameters: cannot have both requestCache and requestCacheOnDisk set to true"); |
There was a problem hiding this comment.
Would these exceptions actually reach whatever is returned to the user who made the poorly formatted API call?
There was a problem hiding this comment.
Ya it does
There was a problem hiding this comment.
btw i changed requestCache to request in the error because the flag we pass to clear all entire requestcache is request.
.../test/java/org/opensearch/action/admin/indices/cache/clear/ClearIndicesCacheRequestTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/indices/IndicesRequestCacheTests.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/indices/IndicesRequestCacheTests.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/indices/IndicesRequestCacheDiskTierIT.java
Outdated
Show resolved
Hide resolved
| public void validateInput() { | ||
| if (requestCache && requestCacheOnDisk) { | ||
| throw new IllegalArgumentException("Invalid parameters: cannot have both request and requestCacheOnDisk set to true"); | ||
| } | ||
| if (requestCache && requestCacheOnHeap) { | ||
| throw new IllegalArgumentException("Invalid parameters: cannot have both request and requestCacheOnHeap set to true"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Lets remove this for now and keep it consistent with rest of the actions. Move this logic to the actual function.
Doesn't look much useful to me.
There was a problem hiding this comment.
the validity of the ClearIndicesCacheRequest should be scoped to the ClearIndicesCacheRequest class right ?
the caller of this class i.e RestClearIndicesCacheAction should not be concerned about that.
.../src/main/java/org/opensearch/action/admin/indices/cache/clear/ClearIndicesCacheRequest.java
Show resolved
Hide resolved
Yep, I should have done it. |
kiranprakash154
changed the title
Description
With Tiered caching[Add Link], we will now have multiple tiers of caches, for now it is heap and disk.
We are exposing a way to clear the cache selectively.
Earlier:
POST /my-index/_cache/clear?request=true- would clear the entire request cache.Now:
POST /my-index/_cache/clear?request=true- will clear the entire request cache (heap & disk, if disk is enabled)New parameters
POST /my-index/_cache/clear?requestCacheOnDisk=true- will clear the request cache on disk tier onlyPOST /my-index/_cache/clear?requestCacheOnHeap=true- will clear the request cache on heap tier onlyPOST /my-index/_cache/clear?requestCacheOnDisk=true&requestCacheOnHeap=true- would clear the entire request cache (heap & disk, if disk is enabled)Valid calls:
POST /my-index/_cache/clear?requestCacheOnDisk=truePOST /my-index/_cache/clear?requestCacheOnHeap=truePOST /my-index/_cache/clear?request=truePOST /my-index/_cache/clear?requestCacheOnDisk=true&requestCacheOnHeap=trueInvalid calls:
POST /my-index/_cache/clear?requestCacheOnDisk=true&request=truePOST /my-index/_cache/clear?requestCacheOnHeap=true&request=trueRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.