Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorithm typo for float16 conversion table calculations #1188

Merged
merged 1 commit into from
May 12, 2024

Conversation

almic
Copy link
Contributor

@almic almic commented May 11, 2024

I was looking at the original paper and noticed this number was different. I could not find any issues that would hint that this number was deliberately changed from -24 to -27, so I assume it must have been a mistake.

Fix typo for exponent mapping
@almic almic requested a review from petamoriken as a code owner May 11, 2024 15:45
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (0d82f01) to head (3f1c0f1).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   87.06%   87.09%   +0.03%     
==========================================
  Files          12       12              
  Lines         773      775       +2     
  Branches      146      147       +1     
==========================================
+ Hits          673      675       +2     
  Misses         54       54              
  Partials       46       46              
Flag Coverage Δ
unittests 87.09% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@petamoriken petamoriken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petamoriken petamoriken merged commit bf958e6 into petamoriken:master May 12, 2024
12 checks passed
@almic almic deleted the patch-1 branch May 13, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants