fix(📌): Unpin puppeteer #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
force-pushed
the
ww/unpin-puppeteer
branch
from
da29691
to
6283692
Compare
Robdel12
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In #539, Puppeteer was pinned to a version that was known not to cause browser crashes. Turns out, that that version also crashes, but only in Docker containers where the default shared memory size is too small to properly run Chromium.
Puppeteer passes along the
--disable-dev-shm-usageflag to Chromium to avoid this issue, but the current pinned Puppeteer version uses Chromium 83 which has a bug that causes it to ignore that flag. https://bugs.chromium.org/p/chromium/issues/detail?id=1085829Approach
Newer versions of Puppeteer have come out since we pinned it. This PR unpins it again to use the latest version which seems to avoid other issues outlined in #539 such as missing woff assets.
🤞
This also bumps the version so we can quickly release this soon after merging