Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(🐛): Handle page and snapshot errors #562

Merged
merged 1 commit into from
Sep 9, 2020
Merged

fix(🐛): Handle page and snapshot errors #562

merged 1 commit into from
Sep 9, 2020

Commits on Sep 9, 2020

  1. fix(🐛): Handle page and snapshot errors 

    Sometimes, due to various reasons, the running browser might disconnect from Puppeteer during asset
discovery causing a `target closed` error. This error can happen anytime CDP sends a message to the
browser, such as enabling JS or setting viewport options. Since it is unhandled it can result in the
local server being unable to respond to requests which can then result in request timeouts.
    @wwilsman
    wwilsman committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    acbbdec View commit details
    Browse the repository at this point in the history