Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove @oclif/errors from devDependency list #155

Merged
merged 1 commit into from
Apr 15, 2019
Merged

fix: Remove @oclif/errors from devDependency list #155

merged 1 commit into from
Apr 15, 2019

Conversation

smacgaha
Copy link
Contributor

See #154

@Robdel12 Robdel12 requested a review from djones April 12, 2019 20:43
@Robdel12 Robdel12 changed the title Move @oclif/errors from devDependency to dependency Fix: Move @oclif/errors from devDependency to dependency Apr 12, 2019
@Robdel12 Robdel12 changed the title Fix: Move @oclif/errors from devDependency to dependency fix: Move @oclif/errors from devDependency to dependency Apr 12, 2019
Robdel12
Robdel12 approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@Robdel12 Robdel12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djones this seems like the right move to me.

I hit this error earlier but reinstalling the SDK worked fine. Not sure what kind of resolution yarn/npm is doing.

I do not like the package-lock.json. I have no idea why there are so many diffs in there for this change. I also rarely ever get to install without having changes in my lock file. 👎

@djones
Copy link
Contributor

djones commented Apr 12, 2019

@smacgaha as per discussion on #154 would you mind removing @oclif/errors completely? Then we should be good to merge.

@smacgaha smacgaha force-pushed the move-@oclif/errors-to-dependency branch from d9e29a3 to a39bcde Compare April 15, 2019 15:21
@smacgaha smacgaha changed the title fix: Move @oclif/errors from devDependency to dependency fix: Remove @oclif/errors from devDependency list Apr 15, 2019
@smacgaha
Copy link
Contributor Author

@djones I tested this locally and it worked fine; I think it's good to go.

@djones
Copy link
Contributor

djones commented Apr 15, 2019 •
edited
Loading

Thanks for the contribution @smacgaha 💜

@djones djones merged commit ce68da3 into percy:master Apr 15, 2019
djones pushed a commit that referenced this pull request Apr 15, 2019
@smacgaha @djones
fix: Remove @oclif/errors as a devDependency. Closes #154 (#155)
2f99c5b
djones pushed a commit that referenced this pull request Apr 15, 2019
@semantic-release-bot
chore(release): 0.2.3 [skip ci]
a8bc943 
## [0.2.3](v0.2.2...v0.2.3) (2019-04-15)

### Bug Fixes

* Remove @oclif/errors as a devDependency. Closes [#154](#154) ([#155](#155)) ([2f99c5b](2f99c5b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robdel12 Robdel12 Robdel12 approved these changes

@djones djones Awaiting requested review from djones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smacgaha @djones @Robdel12