Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency error on @oclif/errors #154

Closed
smacgaha opened this issue Apr 12, 2019 · 2 comments
Closed

Dependency error on @oclif/errors #154

smacgaha opened this issue Apr 12, 2019 · 2 comments

Comments

@smacgaha
Copy link
Contributor

When running percy from the runtime (not globally), an error is raised:

Error: Cannot find module '@oclif/errors'

I believe that this is because @oclif/errors is required in the binary, but is only installed as a devDependency.

No idea why this works when installed globally. I suspect it's related to the fact that @oclif/errors is also installed as a dependency of @oclif/command.

@djones
Copy link
Contributor

djones commented Apr 12, 2019

I think we can remove it completely since, as you point out, it is already a dependency of @oclif/command. Also I note that the latest Oclif example project doesn't list it explicitly as a dependency.

@smacgaha
Copy link
Contributor Author

Sure thing, I'll try that out

@djones djones closed this as completed in 2f99c5b Apr 15, 2019
djones pushed a commit that referenced this issue Apr 15, 2019
## [0.2.3](v0.2.2...v0.2.3) (2019-04-15)

### Bug Fixes

* Remove @oclif/errors as a devDependency. Closes [#154](#154) ([#155](#155)) ([2f99c5b](2f99c5b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants