Throttle Logs Endpoint from CLI #1734
Open
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandeepsingh333
force-pushed
the
PPLT_3337
branch
2 times, most recently
from
fa84987
to
5655d4f
Compare
amandeepsingh333
force-pushed
the
PPLT_3337
branch
from
7c3bb83
to
553b416
Compare
packages/core/test/percy.test.js
Outdated
| ])); | ||
| }); | ||
|
|
||
| it('should not call getErrorAnalysis after exceeding the rate limit', async () => { |
There was a problem hiding this comment.
can you update this case for checking multiple logs are not getting printed if we cross threshold
amandeepsingh333
force-pushed
the
PPLT_3337
branch
2 times, most recently
from
ec44d8b
to
8303588
Compare
amandeepsingh333
force-pushed
the
PPLT_3337
branch
from
8303588
to
1e1e6fc
Compare
chinmay-browserstack
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem :
if large number(500) of snapshots are failing or have some issues for the customer then we are causing Rate limiting to get triggered on
api/v1/suggestions/from_logsas we fetch suggestions for all snapshots. This triggers alert on our side.approach:
To tackle this we have CLI in a way that we dont ask for more than 10 suggestions per build. We are basically limiting the maximum suggestions we can suggest per build. The idea is that if all snapshots are getting some suggestions in build they would be probably same.
implementation:
we have stored a counter of suggestionsCalls and will stop the call to end the count is > 10.