Fixed behaviour of PERCY_POSTINSTALL_BROWSER #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As per #1687 we are only looking at if
PERCY_POSTINSTALL_BROWSERenv var is set and not its value. Causing us to install browser even ifPERCY_POSTINSTALL_BROWSER=falsei.e. its set to false.Updating check to confirm that the flag is set and value is not in 0 or false.
This still means something like
PERCY_POSTINSTALL_BROWSER=noorPERCY_POSTINSTALL_BROWSER=abcdforPERCY_POSTINSTALL_BROWSER=nullwould still trigger browser download but we are not trying to handle every possible condition and we want to be as backwards compatible as possible.This PR does break backwards compatibility but in obviously correct cases [ which is more like a bug in older versions ]