Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partition_prune testcase #440

Merged
merged 12 commits into from
Apr 9, 2024
Merged

Fix partition_prune testcase #440

merged 12 commits into from
Apr 9, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Apr 1, 2024

Fixes #423

compute_query_id parameter has special value regress that allows pg_stat_monitor to have query identifier but hides it in EXPLAINs to let regression testing pass.

https://www.postgresql.org/docs/current/runtime-config-statistics.html#GUC-COMPUTE-QUERY-ID

@artemgavrilov artemgavrilov changed the title Debug CI Fix partition_prune testcase Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (3d84610) to head (00bc98b).
Report is 4 commits behind head on main.

❗ Current head 00bc98b differs from pull request most recent head 05f5e2d. Consider uploading reports for the commit 05f5e2d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   90.55%   90.56%           
=======================================
  Files           3        3           
  Lines        1271     1272    +1     
  Branches       35       35           
=======================================
+ Hits         1151     1152    +1     
  Misses         98       98           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review April 2, 2024 16:51
@Naeem-Akhter
Copy link
Contributor

@artemgavrilov

Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

@artemgavrilov
Copy link
Contributor Author

@artemgavrilov

Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

Mmm, all 3 (14/15/16) workflows were edited.
Screenshot 2024-04-09 at 13 58 48

@Naeem-Akhter
Copy link
Contributor

Naeem-Akhter commented Apr 9, 2024

@artemgavrilov
Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

Mmm, all 3 (14/15/16) workflows were edited. Screenshot 2024-04-09 at 13 58 48

Then I guess, somehow GH was showing me wrong diff of changes. But change is reflected in your working branch. :)

Thanks!

Copy link
Contributor

@Naeem-Akhter Naeem-Akhter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemgavrilov artemgavrilov merged commit 7829869 into main Apr 9, 2024
14 of 22 checks passed
@artemgavrilov artemgavrilov deleted the artem-debug-ci branch April 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partition_prune testcase fails in pgcheck while running installcheck-world with PGSM loaded into server.
3 participants