PG-564 #349
Closed
PG-564 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
PG 15 requires additional shared memory and LWLocks requests to be made from the newly introduced shmem_request_hook and disallows the requests initiated from outside the hook. The commit makes moves the additional shared memory and LWLocks requests from _PG_init to shmem_request_hook for PG15
PG-520 pg_stat_monitor does not work with PG15
Following changes are included in this commit: 1. Updated pgsm.pm to enable runtime loading of PG server version dependent perl modules that are needed for TAP testing. Similarly removed unneeded code from this file that is not needed right now. 2. Added generic settings and helper functions to pgsm.pm that could be used across different test cases. 3.Updated following TAP test case to use pgsm.pm based global settings and helper functions while making sure that we reduce the clutter and duplicate code in test cases, where possible. t/001_settings_default.pl t/002_settings_pgsm_track_planning.pl t/003_settings_pgms_extract_comments.pl t/004_settings_pgsm_track.pl t/005_settings_pgsm_enable_query_plan.pl t/006_settings_pgsm_overflow_target.pl t/007_settings_pgsm_query_shared_buffer.pl t/008_settings_pgsm_histogram_buckets.pl t/009_settings_pgsm_histogram_max.pl t/010_settings_pgsm_histogram_min.pl t/011_settings_pgsm_bucket_time.pl t/012_settings_pgsm_max_buckets.pl t/013_settings_pgsm_normalized_query.pl t/014_settings_pgsm_track_utility.pl t/015_settings_pgsm_query_max_len.pl t/016_settings_pgsm_max.pl t/017_execution_stats.pl t/019_insufficient_shared_space.pl t/020_buffer_overflow.pl t/021_misc_1.pl t/022_misc_2.pl t/023_missing_queries.pl t/024_check_timings.pl t/025_compare_pgss.pl t/026_shared_blocks.pl t/027_local_blocks.pl t/028_temp_block.pl 4. Removed following TAP test cases as these are no longer needed and are covered by existing other test cases. 0001_settings_pgsm_track_planning.pl 0002_settings_pgsm_enable_query_plan.pl 5. Added more out files for histogram sql test cases to cover the behavior for bucket_start_time and server versions. regression/expected/histogram_3.out regression/expected/histogram_4.out regression/expected/histogram_5.out regression/expected/histogram_6.out 6. Added following out file that is PG server version 15 specific. t/expected/007_settings_pgsm_query_shared_buffer.out.15
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
PG-526: bump version to 1.1.1 and adding release notes
PG-462: adding PG15 build to our workflows
* PMM-7 Fix the github action * PMM-7 fix version 12 * PMM-7 Fix Typo * PMM-7 Fix Typo * PMM-7 Increase timeout * PMM-7 Increase timeout * PMM-7 Add support for pgsql13 * PMM-7 Adding support for PG 14 * PMM-7 Increase timer * PMM-7 Adding integration with PG15 * PMM-7 Handle PG 11 changes * PMM-7 handle PG 12 changes * PMM-7 Temp commit for regression * PMM-7 Adding commit * PMM-7 UI tests branch * PMM-7 Revert temp branch * PMM-7 Revert temp branch * PMM-7 revert temp branch * PMM-7 Revert the changes
|
|
|
Hi @kayform, thanks a lot for your contribution. Could you please create your PR against the main branch? It seems you've worked against the REL1_1_1 branch, which now adds 8 additional commits. Also please squash your commits into a single one. |
|
Closing in favor of #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a column to pg_stat_monitor by extracting the bind parameter from each statement.