Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-519 Extensions endpoint #672

Closed
wants to merge 2 commits into from

Conversation

timorusky
Copy link
Contributor

@timorusky timorusky commented Feb 19, 2024

K8SPG-519 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
When installing custom extensions it is not possible to point to a custom s3 object storage endpoint.

Cause:
The s3 SDK within the extension installer is only minimally configured, currently using default values.

Solution:
Add an optional flag to the extension installer named endpoint and configure the s3 SDK appropriately.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@it-percona-cla
Copy link

it-percona-cla commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions failure
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
upgrade-minor passed
users passed
We run 12 out of 12

commit: ac94c37
image: perconalab/percona-postgresql-operator:PR-672-ac94c37de

@spron-in
Copy link
Collaborator

fixes #670

@spron-in spron-in changed the title Extensions endpoint K8SPG-519 Extensions endpoint Mar 14, 2024
@egegunes
Copy link
Contributor

@timorusky code LGTM, could you please check the custom-extensions test?

@egegunes
Copy link
Contributor

@timorusky ping

@timorusky
Copy link
Contributor Author

@egegunes due to the delayed response on my initial request, I've moved on to work with another operator and am no longer interested in pursuing the development of this feature. I am sorry for any inconvenience this may cause.

@egegunes
Copy link
Contributor

@timorusky it's OK, we'll take over from here. thank you for your contribution

@egegunes egegunes removed their assignment Apr 19, 2024
@hors hors closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants