Pbm 88 adding storages #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestgGlobalWithDaemon and TestBackupToS3 are passing. I didn't remove iyet the old DestinationType, DestinationDir and other fields that are going to be deprecated just to jave a starting point where backups are working with the new storage but wihout code cleanup.
Now the restore uses a new reader pkg that creates the readers chain. Code cleanup hasn't been made yet. There are a lot of commented out lines that will be removed after implementing and testing an S3 reader.
Added list storages command but still need to validate storages
golangcibot
reviewed
Feb 6, 2019
| } | ||
|
|
||
| createTempDir() | ||
| createTempBucket(storages.Storages["s3-us-west"].S3) |
There was a problem hiding this comment.
Error return value of createTempBucket is not checked (from errcheck)
|
|
||
| func createTempDir() { | ||
| if _, err := os.Stat(tmpDir); os.IsNotExist(err) { | ||
| os.MkdirAll(tmpDir, os.ModePerm) |
There was a problem hiding this comment.
Error return value of os.MkdirAll is not checked (from errcheck)
| if err != nil { | ||
| t.Fatalf("Cannot get storage %q: %s", storageName, err) | ||
| } | ||
| err = os.MkdirAll(localStg.Filesystem.Path, os.ModePerm) |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| // and the oplog generator is starting to count from 101 sequentially, so last inserted document = count | ||
| rs1BeforeCount := int64(rs1LastOplogDoc["o"].(bson.M)["number"].(int)) | ||
| rs2BeforeCount := int64(rs2LastOplogDoc["o"].(bson.M)["number"].(int)) | ||
| rs1AfterCount, err := s1Session.DB(dbName).C(colName).Find(nil).Count() |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| rs1BeforeCount := int64(rs1LastOplogDoc["o"].(bson.M)["number"].(int)) | ||
| rs2BeforeCount := int64(rs2LastOplogDoc["o"].(bson.M)["number"].(int)) | ||
| rs1AfterCount, err := s1Session.DB(dbName).C(colName).Find(nil).Count() | ||
| rs2AfterCount, err := s2Session.DB(dbName).C(colName).Find(nil).Count() |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
timvaillancourt
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.