Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12510 correctly recognize arbiter nodes #755

Merged
merged 20 commits into from
Jan 17, 2024

Conversation

exporter/v1_compatibility_test.go Outdated Show resolved Hide resolved
exporter/v1_compatibility_test.go Outdated Show resolved Hide resolved
exporter/v1_compatibility_test.go Outdated Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Outdated Show resolved Hide resolved
internal/tu/testutils.go Outdated Show resolved Hide resolved
internal/proto/replstatus.go Show resolved Hide resolved
internal/util/util.go Outdated Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Outdated Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Outdated Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Outdated Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Show resolved Hide resolved
internal/util/util.go Show resolved Hide resolved
exporter/diagnostic_data_collector_test.go Show resolved Hide resolved
internal/proto/replstatus.go Outdated Show resolved Hide resolved
exporter/v1_compatibility_test.go Show resolved Hide resolved
exporter/v1_compatibility_test.go Outdated Show resolved Hide resolved
@idoqo idoqo marked this pull request as ready for review December 13, 2023 19:39
@idoqo idoqo requested a review from a team as a code owner December 13, 2023 19:39
@idoqo idoqo requested review from BupycHuk, JiriCtvrtka, ademidoff, artemgavrilov and a team and removed request for a team December 13, 2023 19:39
internal/util/util.go Show resolved Hide resolved
internal/util/util.go Show resolved Hide resolved
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved

err := client.Database("admin").RunCommand(ctx, bson.M{"getDiagnosticData": 1}).Decode(&ms)
err := client.Database("admin").RunCommand(ctx, bson.M{"replSetGetStatus": 1}).Decode(&status)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you discussed it with @nethalo or @igroene?

JiriCtvrtka and others added 4 commits January 15, 2024 09:57
* PMM-12712 Shard ID and count.

* PMM-12712 Name and count.

* PMM-12712 Sharded collector.

* PMM-12712 Remove missed print.

* PMM-12712 Revert test changes.

* PMM-12712 Revert old not related changes.

* PMM-12712 Another changes.

* PMM-12712 Missed print.

* PMM-12712 Align naming with task description.

* PMM-12712 Add mongos test client.

* PMM-12712 Lint.

* PMM-12712 Lint.

* PMM-12712 Typo.

* PMM-12712 Lint.

* PMM-12712 Test higher sleep.

* Revert "PMM-12712 Test higher sleep."

This reverts commit 88451ba.

* PMM-12712 Test of pipeline.

* PMM-12712 Change.

* PMM-12712 Test.

* PMM-12712 Test.

* PMM-12712 Test.

* PMM-12712 Correct aggregation to get chunks info.

* PMM-12712 Another progress.

* PMM-12702 Small refactor.

* PMM-12712 Test.

* PMM-12712 Fix, tests.

* PMM-12712 Temp.

* PMM-12712 Improve sharded test.

* PMM-12712 Change in workflow.

* PMM-12712 Remove print.

* PMM-12712 Init script changes.

* PMM-12712 Remove print.

* PMM-12712 Bigger sleep.

* PMM-12712 Refactor.

* PMM-12712 Small refactor.

* PMM-12712 Another refactor.

* PMM-12712 Fix after refactor.

* PMM-12712 Alias.

* PMM-12712 Alias for shell in older versions.

* PMM-12712 Static test shard.

* PMM-12712 Fix another tests, mongo 4 shell script.

* PMM-12712 Big sleep test.

* PMM-12712 Michael's fix.

* PMM-12712 Sleep.

* PMM-12712 Env.

* PMM-12712 Test.

* PMM-12712 Fix test.

* PMM-12712 Bigger sleep after changes.

* PMM-12712 Remove duplicate lines.

* PMM-12712 Renaming from sharded to shards.

* PMM-12712 Better script to detect proper mongo client.

* PMM-12712 Init script refactor.

* PMM-12712 Fix.

* PMM-12712 Small refactor.

* Update main.go

Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>

* Update exporter/shards_collector.go

Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>

* PMM-12712 Remove mongo 6 for now, skip test for shards.

* PMM-12712 Revert sleep length.

* PMM-12712 Mongo client based on vendor.

---------

Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>
@idoqo idoqo merged commit b173af7 into main Jan 17, 2024
7 checks passed
@idoqo idoqo deleted the PMM-12510-correctly-recognize-arbiter-nodes branch January 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants