Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1248 Horizontal and Vertical Line Snapping for Drawing Tools #1830

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ortolanmiles
Copy link

Added functionality for pen, pencil, brush and eraser to enter a snapping mode when drawing on a bitmap layer. Drawing movement will be locked to be either horizontal or vertical from the original click location. This covers issue number 1248 for all tools except the polyline tool. Preview of the line is generated, and stroke is only fully committed to the canvas after a pointer release event. RIght now the hotkey for this is '-'.

I believe this change is ready to be merged into the project, but please let me know if there is anything that needs to be changed

Screen.Recording.2024-04-25.at.10.01.57.PM.mov

…pentool. However, changes that would be used in the other tools' implementation have been made to scribblearea, stroketool, and strokeinterpolator
…ted out non-functioning vector implementation on pentool
@scribblemaniac
Copy link
Member

Hello @ortolanmiles. I just wanted to thank you for your contribution. I know there has not been any activity on this the past month but rest assured, we will get to reviewing your contribution. We are just in the middle of making a new release, which is always quite a process for us. We are also holding off on merging any new features like this until after the release to reduce the risk of introducing new bugs right before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

4 participants