Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes missing popups #141

Merged
merged 11 commits into from
Sep 23, 2020
Merged

FIxes missing popups #141

merged 11 commits into from
Sep 23, 2020

Conversation

gtache
Copy link
Contributor

@gtache gtache commented Sep 11, 2020

Fixes #140

@pcorless
Copy link
Owner

This is interesting. So I'm guessing if you double-click on the parent annotation the popup component will be created and shown? But otherwise the popup is in an invisible on first load?

@gtache
Copy link
Contributor Author

gtache commented Sep 22, 2020

No, in fact it causes a NullPointerException in togglePopupAnnotationVisibility, as getPopupAnnotationComponent will return null because the PopupAnnotationComponent is not contained in the PageViewComponent components.
Here is the file causing this problem:
NoPopup.pdf

@pcorless pcorless merged commit 6373168 into pcorless:master Sep 23, 2020
@gtache gtache deleted the missingPopups branch September 23, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup Annotations not being referenced in page annotations
2 participants