-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination with index #133
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2f91945
Fixes conflict with PropertiesManager renaming
gtache 693213f
Merge branch 'master' of github.com:pcorless/icepdf
gtache db0b33f
Merge branch 'master' of github.com:pcorless/icepdf
gtache a4b0f97
Merge branch 'master' of github.com:pcorless/icepdf
gtache f3f99cd
Merge branch 'master' of github.com:pcorless/icepdf
gtache ef55851
Merge branch 'master' of github.com:pcorless/icepdf
gtache ac12aaa
Merge branch 'master' of github.com:pcorless/icepdf
gtache 8b28b29
Merge branch 'master' of github.com:pcorless/icepdf
gtache 3a48551
GH-132 Fixes destination pointing to a page number instead of a page …
gtache 80c6d1f
GH-132 Removes PageTree field in Destination
gtache File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably suggest somthing like, not point keeping the pageTree reference around:
// Dest could be a page number instead of a reference
final int idx = (int) ob;
PageTree pageTree = library.getCatalog().getPageTree();
if (idx >= 0 && idx < pageTree.getNumberOfPages()) {
ref = pageTree.getPageReference(idx);
}
Interstingly this is one of those special corners cases were the notion isn't in the specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I was tired, I was assuming we didn't have access to library in this object for some reason...
Thanks for pointing that out.
Yeah I found that quite strange, I don't know how that pdf got created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries and thank you for providing the fix!