Choose which tool to autoselect #122
Conversation
| @@ -376,6 +376,13 @@ public WindowManagementCallback getWindowManagementCallback() { | |||
| */ | |||
| public void setPropertiesManager(ViewerPropertiesManager propertiesManager) { | |||
| this.propertiesManager = propertiesManager; | |||
| //Migrate old boolean property to new int property | |||
There was a problem hiding this comment.
Ugh, never really had to think about migrating properties before. How did you decide on PROPERTY_ANNOTATION_INK_SELECTION_ENABLED as the property to set off of? What I might suggest as an alternative is changing the properties keys. The next release is going to be major so we can break anything we can get our hands on api wise. Perhaps change the keys ICEpdfDEfault.properties and similarly in ViewerPropertiesManager to something like this:
application.annotation.highlight.selection.enabled -> application.annotation.highlight.selection.type
Thoughts?
There was a problem hiding this comment.
Well, if I remember well I just picked one of them at random, assuming that most people would have the same value for every option.
That'd be cleaner to do that indeed, I think it's a good idea. But I'm wondering if it makes sense to have a property for each annotation tool or if one for all of them would be sufficient?
There was a problem hiding this comment.
The original implementation was a separate setting for each tool. I guess this could still be done but it's going to get messy in the properties panel. Perhaps separate properties but still unify as one in the properties panel so they could be tweaked at a later date. I'll leave it up to you as you have good understanding of what your users need.
Closes #121