Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes and bugfix #51

Closed
gtache opened this issue Feb 13, 2020 · 0 comments · Fixed by #52
Closed

Small changes and bugfix #51

gtache opened this issue Feb 13, 2020 · 0 comments · Fixed by #52

Comments

@gtache
Copy link
Contributor

gtache commented Feb 13, 2020 •
edited
Loading

  • Locks annotationComponents on refresh (Somehow got a ConcurrentModificationException)
  • Adds getControllers to WindowManager
  • Changes MarkupAnnotation toString (for better debugging mainly)
  • Fixes AnnotationComparator page sorting
gtache added a commit to gtache/icepdf that referenced this issue Feb 13, 2020
@gtache
pcorlessGH-51 Changes MarkupAnnotation toString, adds getControllers,…
2281084 
… sync annotationComponents on refresh
@gtache gtache mentioned this issue Feb 13, 2020
Merged
gtache added a commit to gtache/icepdf that referenced this issue Feb 13, 2020
@gtache
pcorlessGH-51 Synchronizes after nullcheck
412ba6b
gtache added a commit to gtache/icepdf that referenced this issue Feb 17, 2020
@gtache
pcorlessGH-51 Fixes AnnotationComparator page sorting
a0f5fe0
gtache added a commit to gtache/icepdf that referenced this issue Feb 17, 2020
@gtache
pcorlessGH-51 Use Integer.compare for comparator
c52895b
pcorless pushed a commit that referenced this issue Mar 4, 2020
@gtache
Some small changes (#52)
f99be67 
* GH-51 Changes MarkupAnnotation toString, adds getControllers, sync annotationComponents on refresh
* GH-51 Synchronizes after nullcheck
* GH-51 Fixes AnnotationComparator page sorting
* GH-51 Use Integer.compare for comparator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some small changes gtache/icepdf
1 participant
@gtache