Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Toolbar #2

Closed
pcorless opened this issue Jan 17, 2020 · 2 comments
Closed

Search Toolbar #2

pcorless opened this issue Jan 17, 2020 · 2 comments
Labels
enhancement New feature or request Viewer Viewer Module

Comments

@pcorless
Copy link
Owner

A community member has requested that we create a new toolbar for quick search. The menu bar would allow to the user to enter search terms, cursors buttons for next and previous terms. There would also be an advanced menu for changes search settings, similar to the search tab in the utility panel.
@pcorless pcorless added the enhancement New feature or request label Jan 17, 2020
@pcorless
Copy link
Owner Author

This bug is track followup changes and to allow searching of markup annotation text.

@pcorless pcorless added this to the 6.4.0 milestone Jan 30, 2020
gtache added a commit to gtache/icepdf that referenced this issue Jan 30, 2020
@gtache
pcorlessGH-2 Makes simple search dynamically show results ; makes sim…
1eed3bf 
…ple search focused with ctrl+f, advanced with ctrl+shift+f ; filters popup doesn't disappear when clicked
@gtache gtache mentioned this issue Jan 30, 2020
Merged
@pcorless pcorless added the Viewer Viewer Module label Jan 31, 2020
gtache added a commit to gtache/icepdf that referenced this issue Feb 6, 2020
@gtache
pcorlessGH-2 BaseSearchComponent -> BaseSearchModel, SearchFilterButt…
708f851 
…onWrapper -> SearchFilterButton, fixes disabling DropDownButton, show advanced search menu item, don't trigger search if textfield is empty
gtache added a commit to gtache/icepdf that referenced this issue Feb 11, 2020
@gtache
pcorlessGH-2 Renames searchPanel -> searchModel
9e8562e
pcorless pushed a commit that referenced this issue Feb 12, 2020
@gtache
Improves the search toolbar (#12)
4263a75 
* GH-2 Makes simple search dynamically show results ; makes simple search focused with ctrl+f, advanced with ctrl+shift+f ; filters popup doesn't disappear when clicked
* GH-2 BaseSearchComponent -> BaseSearchModel, SearchFilterButtonWrapper -> SearchFilterButton, fixes disabling DropDownButton, show advanced search menu item, don't trigger search if textfield is empty
* GH-2 Renames searchPanel -> searchModel
gtache added a commit to gtache/icepdf that referenced this issue Feb 13, 2020
@gtache
pcorlessGH-2 Fixes PersistentJCheckboxMenuItem UI in case SynthUI is …
87122b1 
…not available
pcorless pushed a commit that referenced this issue Feb 27, 2020
@gtache
Fix persistent JCheckboxMenuItemUI (#48)
3304474 
GH-2 Fixes PersistentJCheckboxMenuItem UI in case SynthUI is not available
@pcorless
Copy link
Owner Author

Feature is complete, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Viewer Viewer Module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcorless