TST: add missing dependency that reveals failing tests from pcds-envs #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
blark
as a dev/test dependency, in an attempt to reveal a test that fails on pcds-envs but doesn't run at all in the test suite here.Motivation and Context
In pcds-envs on the weekly build, whatrecord was failing with this message:
I checked this repo and found that this test never gets run, and I think it's because there's an import error raised here:
whatrecord/whatrecord/tests/test_serialization.py
Line 57 in 16a9903
whatrecord/whatrecord/plugins/twincat_pytmc.py
Line 28 in 16a9903
Which is because
blark
isn't installed in the during the test suite.How Has This Been Tested?
n/a, I just want to see if the test that fails on pcds-envs also fails on the base whatrecord repo
it's good to catch these earlier and I think all tests being run is the desired behavior
Where Has This Been Documented?
n/a