Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating presentment currencies #150

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

SatheeshKS10
Copy link
Contributor

@SatheeshKS10 SatheeshKS10 commented Jul 1, 2024

To support the SDK transactions with presentment currencies, below list of currencies are added to the supported currencies list.

Presentment Currencies List:
KHR, MRU, PAB, SLE, XPF, AMD, AZN, BHD, BDT, BZD, KHR,
GEL, GHS, HTG, JOD, KZT, KWD, KGS, LSL, LRD, MOP, MWK,
MAD, MZN, NGN, OMR, PKR, RWF, TND, TMT, UGX, UAH, UZS,
MRU, STN, ZMW, BWP, XOF, ZAR

@SatheeshKS10 SatheeshKS10 requested a review from a team as a code owner July 1, 2024 17:55
@SatheeshKS10
Copy link
Contributor Author

retest this please

@nikrom17
Copy link
Contributor

nikrom17 commented Jul 1, 2024

Hi @SatheeshKS10, it looks like the build is failing for this repo and its an error we've seen in other sdk repos before when running the flow-typed command. Here is a link to a PR with the changes you will need to make to get the builds running again.

Can you please create a new PR with similar changes and get that merged before this one?

@SatheeshKS10
Copy link
Contributor Author

Hi @SatheeshKS10, it looks like the build is failing for this repo and its an error we've seen in other sdk repos before when running the flow-typed command. Here is a link to a PR with the changes you will need to make to get the builds running again.

Can you please create a new PR with similar changes and get that merged before this one?

Thanks @nikrom17, I suggest letting the SDK team handle the build issue fix, as I am not familiar with the configuration files needed to resolve this issue.

@nikrom17 nikrom17 merged commit c24e9de into paypal:main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants