-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hictk and use Arrow to construct DFs of pixels #56
Open
robomics
wants to merge
13
commits into
main
Choose a base branch
from
perf/fetch-df
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robomics
commented
Jun 18, 2024
•
edited
Loading
edited
- Bump hictk to v1.0.0
- Let hictk handle DataFrame construction using Arrow
I wonder if the CI failure is caused by one of the many problems related with the latest updates to MSVC on windows-2022. |
robomics
changed the title
Rely on Arrow to fetch pixels as DFs
Bump hictk and use Arrow to construct DFs of pixels
Jun 18, 2024
This reverts commit be39592.
Found the reason of the weird segfaults on Windows: paulsengroup/hictk#200 |
Need to wait for hictk v1.1.0 to be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.