Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fetching interactions from the lower triangle when it makes sense #179

Merged
merged 25 commits into from
May 23, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented May 22, 2024

Support fetching interactions from the matrix lower triangle in the following scenarios:

  • Query is materialized as a sparse matrix
  • Query is materialized as a dense matrix
  • Query is materialized as a table of pixels

Iterating over pixels from the lower triangle is not (and will never be) possible, as doing so would require pre-loading and re-sorting all pixels overlapping a query (defeating the purpose of iterators).

Closes #174
Closes #175

@robomics robomics changed the title Partial support for fetching interactions from the lower triangle Support for fetching interactions from the lower triangle when it makes sense May 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.75000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 85.10%. Comparing base (9f426e7) to head (627bd08).
Report is 21 commits behind head on main.

Files Patch % Lines
...lude/hictk/transformers/impl/to_dataframe_impl.hpp 92.99% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   84.91%   85.10%   +0.18%     
==========================================
  Files         119      120       +1     
  Lines       10076    10305     +229     
==========================================
+ Hits         8556     8770     +214     
- Misses       1520     1535      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 37e3644 into main May 23, 2024
51 checks passed
@robomics robomics deleted the feature/query-mirroring branch May 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants