Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allot of jsdoc. #250

Merged
merged 6 commits into from
Mar 20, 2020
Merged

Added allot of jsdoc. #250

merged 6 commits into from
Mar 20, 2020

Conversation

XmiliaH
Copy link
Collaborator

@XmiliaH XmiliaH commented Oct 6, 2019

Also added VM.setGlobals, VM.setGlobal, VM.getGlobal to easily set and get globals.
VM.runFile was added to load a file and run its contents.
Fixed that Boolean, Number, String objects were wrongly converted.
Load and compile sandbox.js more lazy. Also moved all the different Caches into one CACHE.
Use one global HOST object with all the host objects.

@XmiliaH
Copy link
Collaborator Author

XmiliaH commented Oct 6, 2019

Also let NodeVM extend VM since they have so much in common.

@stale
Copy link

stale bot commented Jan 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2020
@XmiliaH XmiliaH removed the stale label Jan 6, 2020
Also added VM.setGlobals, VM.setGlobal, VM.getGlobal to easily set and get globals.
VM.runFile was added to load a file and run its contents.
Fixed that Boolean, Number, String objects were wrongly converted.
Load and compile sandbox.js more lazy. Also moved all the different Caches into one CACHE.
Use one global HOST object with all the host objects.
@patriksimek patriksimek merged commit d71d647 into patriksimek:master Mar 20, 2020
@patriksimek
Copy link
Owner

Thanks! This is really great.

@XmiliaH XmiliaH deleted the cleanup branch March 20, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants