Add option to skip unknown record fields #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for the quick fix. This looks good to me, I can do a couple of tidy ups after this and do a release :)) |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 14, 2022
CHANGES: - Add custom `to_yaml` and `of_yaml` attributes (patricoferris/ppx_deriving_yaml#38, @patricoferris) - Add `skip_unknown` flag to allow partially decoding yaml (patricoferris/ppx_deriving_yaml#40, @code-ghalib) - Hide record fields with default values in to_yaml output (patricoferris/ppx_deriving_yaml#37, @maurobringolf, reviewed by @sim642 and @patricoferris) - Expose `to_yaml` and `of_yaml` derivers with `yaml` being an alias (patricoferris/ppx_deriving_yaml#36, @patricoferris) - Improved error messages (patricoferris/ppx_deriving_yaml#32, @prosper74, reviewed by @patricoferris) - Add a default attribute for providing placeholder values (patricoferris/ppx_deriving_yaml#31, @prosper74, reviewed by @ayc9, @pitag-ha and @patricoferris)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address #39 - let me know if this seems reasonable - I just added an optional flag to skip unknown record fields.