Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the InspectionType property to the `GovernmentIdConfiguration… #278

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

mjspi
Copy link
Collaborator

@mjspi mjspi commented Nov 6, 2023

Added the InspectionType property to the GovernmentIdConfiguration object model.
API reference: Verify Policy | governmentId | inspectionType

Regression tested verify service in TF provider.

TF_LOG=INFO TF_LOG_PATH=`pwd`/output.log TF_ACC=1 go test -v -timeout 240s  -run TestAccVerifyPolicy_ github.com/pingidentity/terraform-provider-pingone/internal/service/verify
=== RUN   TestAccVerifyPolicy_RemovalDrift
=== PAUSE TestAccVerifyPolicy_RemovalDrift
=== RUN   TestAccVerifyPolicy_NewEnv
=== PAUSE TestAccVerifyPolicy_NewEnv
=== RUN   TestAccVerifyPolicy_Full
=== PAUSE TestAccVerifyPolicy_Full
=== RUN   TestAccVerifyPolicy_ValidationChecks
=== PAUSE TestAccVerifyPolicy_ValidationChecks
=== RUN   TestAccVerifyPolicy_BadParameters
=== PAUSE TestAccVerifyPolicy_BadParameters
=== CONT  TestAccVerifyPolicy_BadParameters
=== CONT  TestAccVerifyPolicy_RemovalDrift
=== CONT  TestAccVerifyPolicy_ValidationChecks
=== CONT  TestAccVerifyPolicy_Full
=== CONT  TestAccVerifyPolicy_NewEnv
--- PASS: TestAccVerifyPolicy_ValidationChecks (0.41s)
--- PASS: TestAccVerifyPolicy_BadParameters (5.71s)
--- PASS: TestAccVerifyPolicy_NewEnv (12.10s)
--- PASS: TestAccVerifyPolicy_RemovalDrift (13.97s)
--- PASS: TestAccVerifyPolicy_Full (27.02s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/verify      27.424s

@mjspi mjspi self-assigned this Nov 6, 2023
@mjspi mjspi added the enhancement New feature or request label Nov 6, 2023
@mjspi mjspi marked this pull request as ready for review November 6, 2023 19:40
Copy link
Owner

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@patrickcping patrickcping merged commit c7fdaa2 into main Nov 7, 2023
25 checks passed
@patrickcping patrickcping deleted the support-government_id-inspection-type branch November 7, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants