Corrections to Notification Settings object and API (#203)

* Added `Environment`, `DeliveryMode` and `Whitelist` attributes to the `NotificationsSettings` object. * update changelog * Corrected `DeleteNotificationsSettings` response code and payload * changelog
patrickcping · Jun 27, 2023 · 9907f57 · 9907f57
1 parent 7fd343b
commit 9907f57
Show file tree

Hide file tree

Showing 17 changed files with 627 additions and 37 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,8 +4,11 @@
     * **Bug** Fixed Phone Notification Settings `POST` and `PUT` request payload data model. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
     * **Bug** Corrected `Requests` from object to array in the `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
     * **Bug** Corrected `Name` as required property of `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
+    * **Bug** Corrected `DeleteNotificationsSettings` response code and payload. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
+    * **Bug** Corrected `UpdateNotificationsSettings` request payload. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
     * **Enhancement** Added `Numbers` array to the `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
     * **Enhancement** Added `PhoneDeliverySettings` array to the `EntityArray` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
+    * **Enhancement** Added `Environment`, `DeliveryMode` and `Whitelist` attributes to the `NotificationsSettings` object. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
 * `github.com/patrickcping/pingone-go-sdk-v2/mfa` : [v0.13.0](./mfa/CHANGELOG.md)
     * **Breaking change** Migrated `CreateMFAPushCredentialRequest` and `UpdateMFAPushCredentialRequest` to `MFAPushCredentialRequest`. [#201](https://github.com/patrickcping/pingone-go-sdk-v2/pull/201)
     * **Breaking change** Migrated `EntityArrayEmbeddedPushCredentialsInner` to `MFAPushCredentialResponse`. [#201](https://github.com/patrickcping/pingone-go-sdk-v2/pull/201)

diff --git a/go.work.sum b/go.work.sum
@@ -489,6 +489,7 @@ golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 h1:VLliZ0d+/avPrXXH+OakdXhp
 golang.org/x/lint v0.0.0-20210508222113-6edffad5e616/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
 golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028 h1:4+4C/Iv2U4fMZBiMCc98MG1In4gJY5YRhtpDNeDeHWs=
 golang.org/x/mod v0.5.0/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro=
+golang.org/x/mod v0.11.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
 golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20181023162649-9b4f9f5ad519/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20181220203305-927f97764cc3/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=

diff --git a/management/.openapi-generator/FILES b/management/.openapi-generator/FILES
@@ -249,6 +249,7 @@ docs/EnumNotificationsPolicyCountryLimitDeliveryMethod.md
 docs/EnumNotificationsPolicyCountryLimitType.md
 docs/EnumNotificationsPolicyQuotaDeliveryMethods.md
 docs/EnumNotificationsPolicyQuotaItemType.md
+docs/EnumNotificationsSettingsDeliveryMode.md
 docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomAuthMethod.md
 docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomDeliveryMethod.md
 docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomNumberFormat.md
@@ -447,6 +448,7 @@ docs/NotificationsSettingsReplyTo.md
 docs/NotificationsSettingsRestrictions.md
 docs/NotificationsSettingsRestrictionsSmsVoiceQuota.md
 docs/NotificationsSettingsSMTPApi.md
+docs/NotificationsSettingsWhitelistInner.md
 docs/NotificationsTemplatesApi.md
 docs/ObjectApplication.md
 docs/ObjectEnvironment.md
@@ -754,6 +756,7 @@ model_enum_notifications_policy_country_limit_delivery_method.go
 model_enum_notifications_policy_country_limit_type.go
 model_enum_notifications_policy_quota_delivery_methods.go
 model_enum_notifications_policy_quota_item_type.go
+model_enum_notifications_settings_delivery_mode.go
 model_enum_notifications_settings_phone_delivery_settings_custom_auth_method.go
 model_enum_notifications_settings_phone_delivery_settings_custom_delivery_method.go
 model_enum_notifications_settings_phone_delivery_settings_custom_number_format.go
@@ -929,6 +932,7 @@ model_notifications_settings_phone_delivery_settings_twilio_syniverse_all_of.go
 model_notifications_settings_reply_to.go
 model_notifications_settings_restrictions.go
 model_notifications_settings_restrictions_sms_voice_quota.go
+model_notifications_settings_whitelist_inner.go
 model_object_application.go
 model_object_organization.go
 model_object_population.go

diff --git a/management/CHANGELOG.md b/management/CHANGELOG.md
@@ -3,8 +3,11 @@
 * **Bug** Fixed Phone Notification Settings `POST` and `PUT` request payload data model. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
 * **Bug** Corrected `Requests` from object to array in the `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
 * **Bug** Corrected `Name` as required property of `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
+* **Bug** Corrected `DeleteNotificationsSettings` response code and payload. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
+* **Bug** Corrected `UpdateNotificationsSettings` request payload. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
 * **Enhancement** Added `Numbers` array to the `NotificationsSettingsPhoneDeliverySettingsCustom` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
 * **Enhancement** Added `PhoneDeliverySettings` array to the `EntityArray` object. [#195](https://github.com/patrickcping/pingone-go-sdk-v2/pull/195)
+* **Enhancement** Added `Environment`, `DeliveryMode` and `Whitelist` attributes to the `NotificationsSettings` object. [#203](https://github.com/patrickcping/pingone-go-sdk-v2/pull/203)
 
 # v0.22.0 (2023-05-30)
 

diff --git a/management/README.md b/management/README.md
@@ -571,6 +571,7 @@ Class | Method | HTTP request | Description
  - [EnumNotificationsPolicyCountryLimitType](docs/EnumNotificationsPolicyCountryLimitType.md)
  - [EnumNotificationsPolicyQuotaDeliveryMethods](docs/EnumNotificationsPolicyQuotaDeliveryMethods.md)
  - [EnumNotificationsPolicyQuotaItemType](docs/EnumNotificationsPolicyQuotaItemType.md)
+ - [EnumNotificationsSettingsDeliveryMode](docs/EnumNotificationsSettingsDeliveryMode.md)
  - [EnumNotificationsSettingsPhoneDeliverySettingsCustomAuthMethod](docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomAuthMethod.md)
  - [EnumNotificationsSettingsPhoneDeliverySettingsCustomDeliveryMethod](docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomDeliveryMethod.md)
  - [EnumNotificationsSettingsPhoneDeliverySettingsCustomNumberFormat](docs/EnumNotificationsSettingsPhoneDeliverySettingsCustomNumberFormat.md)
@@ -747,6 +748,7 @@ Class | Method | HTTP request | Description
  - [NotificationsSettingsReplyTo](docs/NotificationsSettingsReplyTo.md)
  - [NotificationsSettingsRestrictions](docs/NotificationsSettingsRestrictions.md)
  - [NotificationsSettingsRestrictionsSmsVoiceQuota](docs/NotificationsSettingsRestrictionsSmsVoiceQuota.md)
+ - [NotificationsSettingsWhitelistInner](docs/NotificationsSettingsWhitelistInner.md)
  - [ObjectApplication](docs/ObjectApplication.md)
  - [ObjectEnvironment](docs/ObjectEnvironment.md)
  - [ObjectOrganization](docs/ObjectOrganization.md)

diff --git a/management/api/openapi.yaml b/management/api/openapi.yaml
@@ -14166,7 +14166,11 @@ paths:
               schema:
                 $ref: '#/components/schemas/P1Error'
           description: Uncaught error occurred.  Platform outage
-        "204":
+        "200":
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/NotificationsSettings'
           description: Successful response
       summary: DELETE Notifications Settings
       tags:
@@ -14238,6 +14242,11 @@ paths:
         schema:
           type: string
         style: simple
+      requestBody:
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/NotificationsSettings'
       responses:
         "400":
           content:
@@ -23490,6 +23499,10 @@ components:
       - USER
       - ENVIRONMENT
       type: string
+    EnumNotificationsSettingsDeliveryMode:
+      enum:
+      - ALL
+      type: string
     EnumNotificationsSettingsPhoneDeliverySettingsCustomDeliveryMethod:
       description: |
         The notification's delivery method. Possible values:
@@ -27451,9 +27464,12 @@ components:
       type: object
     NotificationsSettings:
       example:
+        environment:
+          id: id
         smsProvidersFallbackChain:
         - smsProvidersFallbackChain
         - smsProvidersFallbackChain
+        deliveryMode: null
         replyTo:
           address: address
           name: name
@@ -27464,13 +27480,22 @@ components:
           address: address
           name: name
         id: id
+        whitelist:
+        - user:
+            id: id
+        - user:
+            id: id
         updatedAt: 2000-01-23T04:56:07.000+00:00
       properties:
         updatedAt:
           description: The time the resource was last updated.
           format: date-time
           readOnly: true
           type: string
+        environment:
+          $ref: '#/components/schemas/ObjectEnvironment'
+        deliveryMode:
+          $ref: '#/components/schemas/EnumNotificationsSettingsDeliveryMode'
         restrictions:
           $ref: '#/components/schemas/NotificationsSettings_restrictions'
         id:
@@ -27499,6 +27524,10 @@ components:
           $ref: '#/components/schemas/NotificationsSettings_from'
         replyTo:
           $ref: '#/components/schemas/NotificationsSettings_replyTo'
+        whitelist:
+          items:
+            $ref: '#/components/schemas/NotificationsSettings_whitelist_inner'
+          type: array
       type: object
     NotificationsSettingsEmailDeliverySettings:
       example:
@@ -29394,6 +29423,8 @@ components:
       - type
       type: object
     Application_accessControl_group_groups_inner:
+      example:
+        id: id
       properties:
         id:
           type: string
@@ -33022,6 +33053,14 @@ components:
             \ for details."
           type: string
       type: object
+    NotificationsSettings_whitelist_inner:
+      example:
+        user:
+          id: id
+      properties:
+        user:
+          $ref: '#/components/schemas/Application_accessControl_group_groups_inner'
+      type: object
     NotificationsSettingsEmailDeliverySettings_from:
       example:
         address: address

diff --git a/management/api_notifications_settings.go b/management/api_notifications_settings.go
diff --git a/management/docs/EnumNotificationsSettingsDeliveryMode.md b/management/docs/EnumNotificationsSettingsDeliveryMode.md
@@ -0,0 +1,11 @@
+# EnumNotificationsSettingsDeliveryMode
+
+## Enum
+
+
+* `ALL` (value: `"ALL"`)
+
+
+[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
+
+